Submission Details
Severity:
Write after write
Summary
Variables that are written but never read and written again.
Vulnerability Details
File: contracts/libraries/Silo/LibUnripeSilo.sol
/// @audit ******************* Issue Detail *******************
LibUnripeSilo.unripeLPDeposit(address,uint32).bdv (contracts/libraries/Silo/LibUnripeSilo.sol#182) is written in both
(amount,bdv) = getBeanEthUnripeLP(account,season) (contracts/libraries/Silo/LibUnripeSilo.sol#188)
bdv = uint256(s.a[account].legacyV2Deposits[C.UNRIPE_LP][season].bdv).add(legBdv) (contracts/libraries/Silo/LibUnripeSilo.sol#205-207)
/// @audit ************** Possible Issue Line(s) **************
L#182, L#188, L#205-207,
/// @audit ****************** Affected Code *******************
182: returns (uint256 amount, uint256 bdv)
188: (amount, bdv) = getBeanEthUnripeLP(account, season);
205: bdv = uint256(
206: s.a[account].legacyV2Deposits[C.UNRIPE_LP][season].bdv
207: ).add(legBdv);
GitHub : 182-182
Impact
Write after write may reflect wrong implementation logic and unnecessary use of gas.
Tools Used
Manual Review
Recommendations
Fix or remove the writes.
Updates
Lead Judging Commences
giovannidisiena over 1 year ago
Submission Judgement Published Reason: Too generic
Assigned finding tags:
Informational/Invalid
Prize pool breakdown
Total prize
100,000 USDC
nSLOC
5,77617 USDC / LOC
95,000 USDC
5,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.