Submission Details
Severity:
Local variable shadowing
Summary
Shadowing of other variables using local variables.
Vulnerability Details
File: contracts/beanstalk/silo/MigrationFacet.sol
/// @audit ******************* Issue Detail *******************
MigrationFacet.getDepositLegacy(address,address,uint32).s (contracts/beanstalk/silo/MigrationFacet.sol#95) shadows:
- ReentrancyGuard.s (contracts/beanstalk/ReentrancyGuard.sol#17) (state variable)
/// @audit ************** Possible Issue Line(s) **************
L#95,
/// @audit ****************** Affected Code *******************
95: AppStorage storage s = LibAppStorage.diamondStorage();
GitHub : 95-95
File: contracts/beanstalk/silo/MigrationFacet.sol
/// @audit ******************* Issue Detail *******************
MigrationFacet.totalMigratedBdv(address).s (contracts/beanstalk/silo/MigrationFacet.sol#116) shadows:
- ReentrancyGuard.s (contracts/beanstalk/ReentrancyGuard.sol#17) (state variable)
/// @audit ************** Possible Issue Line(s) **************
L#116,
/// @audit ****************** Affected Code *******************
116: AppStorage storage s = LibAppStorage.diamondStorage();
GitHub : 116-116
Impact
state Variable shadowing by some local variable will use value of local variable instead of state variable and may lead contract to a wrong state.
Tools Used
Manual Review
Recommendations
Rename the local variables that shadow another component.
Updates
Lead Judging Commences
giovannidisiena over 1 year ago
Submission Judgement Published Reason: Lack of quality
Assigned finding tags:
Informational/Invalid
Prize pool breakdown
Total prize
100,000 USDC
nSLOC
5,77617 USDC / LOC
95,000 USDC
5,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.