Submission Details
Severity:
Missing inheritance
Summary
Contract does not inherit from interface (unimplemented interface).
Vulnerability Details
File: contracts/beanstalk/silo/BDVFacet.sol
/// @audit ******************* Issue Detail *******************
BDVFacet (contracts/beanstalk/silo/BDVFacet.sol#18-71) should inherit from IBDVFacet (contracts/beanstalk/init/InitBipBasinIntegration.sol#20-25)
GitHub : 18-71
File: contracts/beanstalk/sun/GaugePointFacet.sol
/// @audit ******************* Issue Detail *******************
GaugePointFacet (contracts/beanstalk/sun/GaugePointFacet.sol#16-58) should inherit from IGaugePointFacet (contracts/beanstalk/init/InitBipSeedGauge.sol#21-27)
GitHub : 16-58
File: contracts/beanstalk/silo/SiloFacet/SiloGettersFacet.sol
/// @audit ******************* Issue Detail *******************
SiloGettersFacet (contracts/beanstalk/silo/SiloFacet/SiloGettersFacet.sol#23-588) should inherit from IBDV (contracts/ecosystem/price/CurvePrice.sol#13-15)
GitHub : 23-588
File: contracts/beanstalk/sun/LiquidityWeightFacet.sol
/// @audit ******************* Issue Detail *******************
LiquidityWeightFacet (contracts/beanstalk/sun/LiquidityWeightFacet.sol#13-19) should inherit from ILiquidityWeightFacet (contracts/beanstalk/init/InitBipSeedGauge.sol#29-31)
/// @audit ****************** Affected Code *******************
13: contract LiquidityWeightFacet {
14: uint256 constant MAX_WEIGHT = 1e18;
15:
16: function maxWeight() external pure returns (uint256) {
17: return MAX_WEIGHT;
18: }
19: }
GitHub : 13-19
Impact
To ensure correct use of interface, the used contract must inherit from the interface or a base contract.
Tools Used
Manual Review
Recommendations
Inherit from the missing interface or contract.
Updates
Lead Judging Commences
giovannidisiena about 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Informational/Invalid
Prize pool breakdown
Total prize
100,000 USDC
nSLOC
5,77617 USDC / LOC
95,000 USDC
5,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.