DeFiHardhatOracleProxyUpdates
100,000 USDC
View results
Submission Details
Severity: low
Invalid

Unused state variable

Summary

Code has state variables that are never used.

Vulnerability Details

File: contracts/libraries/LibEvaluate.sol
/// @audit ******************* Issue Detail *******************
DecimalExtended (contracts/libraries/LibEvaluate.sol#28-34) has following non-used variables
- DecimalExtended.PERCENT_BASE (contracts/libraries/LibEvaluate.sol#29)
/// @audit ************** Possible Issue Line(s) **************
L#29,
/// @audit ****************** Affected Code *******************
28: library DecimalExtended {
29: uint256 private constant PERCENT_BASE = 1e18;
30:
31: function toDecimal(uint256 a) internal pure returns (Decimal.D256 memory) {
32: return Decimal.D256({ value: a });
33: }
34: }

GitHub : 28-34

File: contracts/libraries/LibIncentive.sol
/// @audit ******************* Issue Detail *******************
LibIncentive (contracts/libraries/LibIncentive.sol#20-233) has following non-used variables
- LibIncentive.PERIOD (contracts/libraries/LibIncentive.sol#31)
/// @audit ************** Possible Issue Line(s) **************
L#31,
/// @audit ****************** Affected Code *******************
31: uint32 internal constant PERIOD = 1800; // 30 minutes

GitHub : 20-233

Impact

Unused state variables should be removed for gas efficiency and readability.

Tools Used

Manual Review

Recommendations

Remove unused state variables.

Updates

Lead Judging Commences

giovannidisiena Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Informational/Invalid

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.