Summary

Some ERC20 tokens do not allow zero value transfers, reverting such attempts.

Vulnerability Details

function addMigratedUnderlying(
address unripeToken,
uint256 amount
) external payable nonReentrant {
LibDiamond.enforceIsContractOwner();
IERC20(s.u[unripeToken].underlyingToken).safeTransferFrom(
msg.sender,
address(this),
@> amount
);
LibUnripe.incrementUnderlying(unripeToken, amount);
}

Impact

Some ERC20 tokens revert on zero value transfers:

https://github.com/d-xo/weird-erc20#revert-on-zero-value-transfers

Tools Used

Recommendations

Vulnerability Details

function addMigratedUnderlying(
address unripeToken,
uint256 amount
) external payable nonReentrant {
LibDiamond.enforceIsContractOwner();
if(amount>0)
{
IERC20(s.u[unripeToken].underlyingToken).safeTransferFrom(
msg.sender,
address(this),
amount
);
}
LibUnripe.incrementUnderlying(unripeToken, amount);
}