Summary

Functions which do not expect ETHer should NOT be payable

Vulnerability Details

The following function do not expect ETher but have the payable modifier.

• EnrootFacet.enrootDeposit(...)

• EnrootFacet.enrootDeposits(...)

• MigrationFacet.mowAndMigrate(...)

• MigrationFacet.mowAndMigrateNoDeposits(...)

When Ether is accidentally sent with this function call, The ETHer is lost to the contract.

Impact

Loss of Ether by the callers of the functions

Tools Used

Manual review

Recommendations

Consider removing the payable modifier from the above functions since they do not expect Ether