DeFiHardhatOracleProxyUpdates
100,000 USDC
View results
Submission Details
Severity: low
Invalid

No form of balance check before token conversion

Summary

No form of balance check before token transfer

Vulnerability Details

The absence of this check can cause a sender to initiate a conversion of fees token more than that of his balance

Impact

This can result in function execution failure, loss of fees or incomplete token conversion(which will make the event indicating completion of token conversion to not be emitted )

Tools Used

VS Code Manual Review

Recommendations

Adding "require(LibSilo.balanceOf(msg.sender, fromToken) >= fromAmount, "Insufficient balance for conversion");" will remediate this issue

Updates

Lead Judging Commences

giovannidisiena Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Lack of quality
Assigned finding tags:

Informational/Invalid

alchmy0 Submitter
about 1 year ago
giovannidisiena Lead Judge
about 1 year ago
giovannidisiena Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Lack of quality
Assigned finding tags:

Informational/Invalid

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.