Submission Details
Severity:
Inconsistent logic used in `RapBattle` Battle event emitter, causing loser to be winner emitted off-chain
Description:
there are different logic used between event emitter Battle and logic function for choosing winner:
RapBattle.sol
@> emit Battle(msg.sender, _tokenId, random < defenderRapperSkill ? _defender : msg.sender);
.
.
.
// If random <= defenderRapperSkill -> defenderRapperSkill wins, otherwise they lose
@> if (random <= defenderRapperSkill) {
Impact:
if the random value is equal to defenderRapperSkill, there would be 2 winner:
offchain winner : challenger
onchain winner : defender
Recommended Mitigation:
use consistent logic for emitted event and function logic.
Below are example of using the function logic and correcting the emitted event:
RapBattle.sol
- emit Battle(msg.sender, _tokenId, random < defenderRapperSkill ? _defender : msg.sender);
+ emit Battle(msg.sender, _tokenId, random <= defenderRapperSkill ? _defender : msg.sender);
.
.
.
// If random <= defenderRapperSkill -> defenderRapperSkill wins, otherwise they lose
if (random <= defenderRapperSkill) {
Updates
Lead Judging Commences
inallhonesty over 1 year ago
Submission Judgement Published Assigned finding tags:
Contradictory battle result event
Rewards breakdown
nSLOC
201This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.