Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: low
Invalid

In `RapBattle::goOnStageOrBattle` function, defender can challenge themself

[L-4] In RapBattle::goOnStageOrBattle function, defender can challenge themself

Description: Defender can challenge themself because there are no check if the defender is not the challenger

Recommended Mitigation: Consider adding msg.sender check to the goOnStageOrBattle

function goOnStageOrBattle(uint256 _tokenId, uint256 _credBet) external {
+ require(defender != msg.sender, "cannot challenge yourself");
if (defender == address(0)) {
defender = msg.sender;
defenderBet = _credBet;
defenderTokenId = _tokenId;
Updates

Lead Judging Commences

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Too generic
farismaulana Submitter
over 1 year ago
inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Too generic

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.