Submission Details
Severity:
`ICredToken` interface missing return values for ERC20 functions
Description: Incorrect return values for ERC20 functions. A contract compiled with Solidity > 0.4.22 interacting with these functions will fail to execute them, as the return value is missing.
Impact: ICredToken.transfer does not return a boolean. Bob deploys the token. Alice creates a contract that interacts with it but assumes a correct ERC20 interface implementation. Alice's contract is unable to interact with Bob's contract.
Recommended Mitigation: Set the appropriate return values and types for the defined ERC20 functions.
- function approve(address to, uint256 amount) external;
+ function approve(address to, uint256 amount) external returns(bool);
- function transfer(address to, uint256 amount) external;
+ function transfer(address to, uint256 amount) external returns(bool);
- function transferFrom(address from, address to, uint256 amount) external;
+ function transferFrom(address from, address to, uint256 amount) external returns(bool);
Rewards breakdown
nSLOC
201This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.