Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: low
Invalid

Unsafe ERC20 Operations should not be used

ERC20 functions may not behave as expected. For example: return values are not always meaningful. It is recommended to use OpenZeppelin's SafeERC20 library.

  • Found in src/RapBattle.sol Line: 46

    oneShotNft.transferFrom(msg.sender, address(this), _tokenId);
  • Found in src/RapBattle.sol Line: 47

    credToken.transferFrom(msg.sender, address(this), _credBet);
  • Found in src/RapBattle.sol Line: 73

    credToken.transfer(_defender, defenderBet);
  • Found in src/RapBattle.sol Line: 74

    credToken.transferFrom(msg.sender, _defender, _credBet);
  • Found in src/RapBattle.sol Line: 77

    credToken.transfer(msg.sender, _credBet);
  • Found in src/RapBattle.sol Line: 81

    oneShotNft.transferFrom(address(this), _defender, defenderTokenId);
  • Found in src/Streets.sol Line: 36

    oneShotContract.transferFrom(msg.sender, address(this), tokenId);
  • Found in src/Streets.sol Line: 82

    oneShotContract.transferFrom(address(this), msg.sender, tokenId);
Updates

Lead Judging Commences

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.