Submission Details
Severity:
Wrong event emission
Summary
Wrong event emission in RapBattle.sol contract
Vulnerability Details
emit Battle(msg.sender, _tokenId, random < defenderRapperSkill ? _defender : msg.sender);
It should be
emit Battle(msg.sender, _tokenId, random <= defenderRapperSkill ? _defender : msg.sender);
to synchronize with the results:
// If random <= defenderRapperSkill -> defenderRapperSkill wins, otherwise they lose
if (random <= defenderRapperSkill) {
// We give them the money the defender deposited, and the challenger's bet
credToken.transfer(_defender, defenderBet);
credToken.transferFrom(msg.sender, _defender, _credBet);
} else {
// Otherwise, since the challenger never sent us the money, we just give the money in the contract
credToken.transfer(msg.sender, _credBet);
}
Impact
Wrong winner announcement.
Tools Used
Manual review
Recommendations
Change to:
emit Battle(msg.sender, _tokenId, random <= defenderRapperSkill ? _defender : msg.sender);
Updates
Lead Judging Commences
inallhonesty over 1 year ago
Submission Judgement Published Assigned finding tags:
Contradictory battle result event
Rewards breakdown
nSLOC
201This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.