Submission Details
Severity:
User fight with their own self
Summary
Their is no guarantee that a defender would go on battle with a challenger that is not their own self
Vulnerability Details
Their is no guarantee that a defender would go on battle with a challenger that is not their own self
Impact
No direct harm to the protocol but this shouldn't be the case.
Tools Used
Manual Review
Recommendations
Add a check.
function goOnStageOrBattle(uint256 _tokenId, uint256 _credBet) external {
if (defender == address(0)) {
defender = msg.sender;
defenderBet = _credBet;
defenderTokenId = _tokenId;
emit OnStage(msg.sender, _tokenId, _credBet);
oneShotNft.transferFrom(msg.sender, address(this), _tokenId);
credToken.transferFrom(msg.sender, address(this), _credBet);
} else {
// credToken.transferFrom(msg.sender, address(this), _credBet);
+ if (msg.sender == defender){
+ revert RapBattle__CanFightYourOwnSelf();
}
_battle(_tokenId, _credBet);
}
}
Rewards breakdown
nSLOC
201This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.