First Flight #10: One Shot
First Flight #10
Beginner FriendlyFoundryNFT
100 EXP
View results
Previous Next
Submission Details
Severity: low
Invalid

Missing events emission in `CredToken::setStreetsContract` and `OneShot::setStreetsContract` prevents it from off-chain track.

shikhar229169

Summary

Missing event emission is found inCredToken::setStreetsContract and OneShot::setStreetsContract functions.
Events play a crucial role to track all the on-chain changes made in a off-chain database, but missing events emission in the functions will make off-chain database not track those changes made.

Vulnerability Details

The vulnerability occurs due to missing events emission in certain functions in CredToken and OneShot contract.
Missing event emission will cause off-chain database to have no track of all the changes made on-chain.

Impact

The changes made on-chain will not be tracked in off-chain database.

Tools Used

Manual Review

Recommendations

Emit event in the setStreetsContract of both CredToken and OneShot contract.

+ event StreetsContractUpdated(address prevStreets, address newStreets);
​
function setStreetsContract(address streetsContract) public onlyOwner {
+ emit StreetsContractUpdated(_streetsContract, streetsContract);
_streetsContract = Streets(streetsContract);
}
Updates

Lead Judging Commences

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.