First Flight #9: Soulmate

Summary

The LoveToken.sol constructor takes airdropVault and stakingVault as arguments. They are initialized in Airdrop.sol, which, needs an implementation of the ILoveToken interface.

Vulnerability Details

The initialization of Vault.sol's vaults (airdropVault and stakingVault) relies on LoveToken.sol being deployed and providing an implementation of the ILoveToken interface. Therefore, LoveToken.sol needs to be deployed before Vault.sol can successfully initialize its vaults.

Impact

For deployment to mainnet or a testnet other than a local environment, the circular dependencies will prevent deployment of LoveToken.sol.

Tools Used

Remix + manual review

Recommendations

Refactoring the contracts to remove circular dependencies or redesigning the deployment process to handle dependencies more efficiently.