First Flight #9: Soulmate
First Flight #9
Beginner FriendlyFoundryNFT
100 EXP
View results
Previous Next
Submission Details
Severity: low
Invalid

Informational and Gas findings

0xlrivo

[INFO-1] Wrong event emission in Soulmate::mintSoulmanteToken()

Summary

The event SoulmateAreReunited is always emitted with address(0) as the value of the soulmate2 parameter because a non-updated memory variable is used in the emission.

Recommendations

replace soulmate2 with msg.sender

- emit SoulmateAreReunited(soulmate1, soulmate2, nextID);
+ emit SoulmateAreReunited(soulmate1, msg.sender, nextID);

[GAS-1] Unused state variable in LoveToken:soulmateContract that can be removed

Summary

ISoulmate public immutable soulmateContract;
Updates

Lead Judging Commences

0xnevi Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.