Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: medium
Invalid

One-Sided Divorce in `Soulmate::getDivorced()` is converted to two-sided

Summary

The Soulmate::getDivorced() function in the provided code sets the 'divorced' mapping to true for both parties involved in a relationship without confirming whether both parties agree to the divorce. This lack of validation could lead to unintended consequences and potential disputes between the parties involved.

Vulnerability Details

The vulnerability lies in the absence of verification to ensure that both parties consent to the divorce before updating the 'divorced' mapping. By unilaterally setting the 'divorced' status to true for both parties, the function does not consider scenarios where one party may not agree to the divorce.

Impact

it can lead to confusion, disputes, and mistrust between the parties involved. Incorrectly marking both parties as divorced without their explicit consent could result in legal or social ramifications, damaging the integrity of the relationship management system.

Tools Used

Manual

Recommendations

It is recommended to implemente a confirmation step where both parties explicitly signal their agreement to the divorce.

Updates

Lead Judging Commences

0xnevi Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Design choice

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.