Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: low
Invalid

Constant variable should be capital in `daysInSeconds::Airdrop.sol`

Summary

Every constant variable should be represented by capital letters [good practice]. And there will be no days in the seconds. Number of seconds will be avialable in a day.

Vulnerability Details

Name the daysInSecond variable as SECONDS_IN_DAY = 3600 * 24

Impact

There will be no impact, but the variable name is not correct.

Tools Used

Mannually

Recommendations

- uint256 public constant daysInSecond = 3600 * 24;
+ uint256 public constant SECONDS_IN_DAY = 3600 * 24;
- soulmateContract.ownerToId(msg.sender))) / daysInSecond;
+ soulmateContract.ownerToId(msg.sender))) / SECONDS_IN_DAY;
Updates

Lead Judging Commences

0xnevi Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.