Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: medium
Invalid

Incorrect return values for ERC20 functions.

Summary

Incorrect erc20 interface for LoveToken and Soulmate

Vulnerability Details

ILoveToken (src/interface/ILoveToken.sol#4-18) has incorrect ERC20 function interface:ILoveToken.approve(address,uint256) (src/interface/ILoveToken.sol#7)

ILoveToken (src/interface/ILoveToken.sol#4-18) has incorrect ERC20 function interface:ILoveToken.transfer(address,uint256) (src/interface/ILoveToken.sol#9)

ILoveToken (src/interface/ILoveToken.sol#4-18) has incorrect ERC20 function interface:ILoveToken.transferFrom(address,address,uint256) (src/interface/ILoveToken.sol#11)

ISoulmate (src/interface/ISoulmate.sol#4-33) has incorrect ERC20 function interface:ISoulmate.transferFrom(address,address,uint256) (src/interface/ISoulmate.sol#17)

Impact

A contract compiled with Solidity > 0.4.22 interacting with these functions will fail to execute them, as the return value is missing.

Tools Used

Slither

Recommendations

Set the appropriate return values and types for the defined ERC20 functions.

Updates

Lead Judging Commences

0xnevi Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Other

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.