Submission Details
Severity:
L1: The staked amount should be incremented after love tokens are deposited
Summary
The deposited amount should be increased just after the transfer has finished, making it a better, safer and bit more gas-efficient solution.
Vulnerability Details
Impact
Tools Used
Static analysis
Recommendations
Change the order of the transferFrom function and userStakes increment in the Staking::deposit function
function deposit(uint256 amount) public {
if (loveToken.balanceOf(address(stakingVault)) == 0)
revert Staking__NoMoreRewards();
// Changed order - better practice
loveToken.transferFrom(msg.sender, address(this), amount);
userStakes[msg.sender] += amount;
emit Deposited(msg.sender, amount);
}
Rewards breakdown
nSLOC
233This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.