First Flight #9: Soulmate

Summary

Vulnerability Details

In this function, it returns at the end of the message a random
word in ‘niceWords’ array, but it not well implemented, it returns a word
doing ‘block.timestamp % nicewords.length”. This is a bad practice
because block.timestamp can be manipulated from the attacker. Also, this
practice will ever returns the word ‘darling’, and not the others ones.

Impact

The message is always read with ‘darling’ as last word.

Tools Used

Foundry

Recommendations

Do not utilize block.timestamp, in order to get
random values consider using chainlink VRFA.