First Flight #9: Soulmate

Summary

While LoveToken adheres to the ERC-20 token standard, its interface, ILoveToken, is inconsistent with the ERC-20 token interface. This discrepancy may lead to user confusion during interactions with the protocol.

Vulnerability Details

The LoveToken contract utilizes the solmate template for ERC-20 tokens. In a standard ERC-20 token, the transfer, transferFrom, and approve functions are expected to return a boolean to indicate the success of the operation.

However, in ILoveToken, the interface for LoveToken, there is a slight difference:

It does not include a return boolean value. Interacting with these functions using a contract compiled with Solidity > 0.4.22 will result in execution failure due to the missing return value.

Impact

If the protocol is deployed and users claim Love Tokens, attempting to interact with the contract using ILoveToken as a reference may prove unsuccessful.

Tools Used

Slither

Recommendations

To solve this issue, update the ILoveToken interface to align with the ERC-20 token standard by adding return values to the transfer, transferFrom, and approve functions.