Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: low
Valid

Use `msg.sender` instead of `soulmate2` in the event emission of `SoulmateAreReunited`.

Summary

The code emits the SoulmateAreReunited event with the wrong parameters. It should use msg.sender instead of soulmate2 for the second soulmate, since soulmate2 is still uninitialized at that point.

Impact

This could cause confusion or misinformation for the event listeners.

Tools Used

Manually

Recommendations

Replace the soulmate2 with msg.sender in the event emission of SoulmateAreReunited:

- emit SoulmateAreReunited(soulmate1, soulmate2, nextID);
+ emit SoulmateAreReunited(soulmate1, msg.sender, nextID);
Updates

Lead Judging Commences

0xnevi Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-mintSoulmateToken-wrong-emit-soulmate2

Low severity, inconsistencies in event emission Sidenote: Separating all event findings given root causes are different with different functions involved. There could be alot of debate on whether wrong emit events consitute low severity, but I believe, - There are direct inconsistencies in the code logic - Codehawks [low severity categorization guidelines](https://docs.codehawks.com/hawks-auditors/how-to-evaluate-a-finding-severity#low-severity-findings) supports its severity as seen below, especially noting the term `Minimal to no impact` > - Minimal to no impact on the funds or the protocol's main functionality.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.