Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: medium
Valid

User can be his own soulmate

Summary

Based on the logic of the Soulmate contract, soulmates are matched sequentially and there is no check if the second soulmate is the same as the 1st one.

Vulnerability Details

mintSoulmateToken() function allows the possibility of being the soulmate of the same user. This can happen if the same user calls the function twice before other users.

Impact

Below PoC can be run to prove the vulnerability:

function test_SamePersonCanBeOwnSoulmate() public {
vm.startPrank(soulmate1);
soulmateContract.mintSoulmateToken();
soulmateContract.mintSoulmateToken();
assertEq(soulmateContract.soulmateOf(soulmate1), soulmate1);
vm.stopPrank();
}

Tools Used

Manual code review

Recommendations

It's recommended to add a check to avoid same person to be his own soulmate:

else if (soulmate != msg.sender) {
revert Soulmate__alreadyHaveASoulmate(soulmate);
}
Updates

Lead Judging Commences

0xnevi Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-self-soulmate

- Given the native anonymous nature of blockchain in general, this issue cannot be avoided unless an explicit whitelist is implemented. Even then we can only confirm soulmates are distinct individuals via kyc. I believe finding a soulmate is intended to be permisionless. - However, even though sufficient (500_000_000e18 in each vault) tokens are minted to claim staking and airdrop rewards, it would take 500_000_000 / 2 combined weeks for airdrop vault to be drained which is not unreasonable given there are [80+ million existing wallets](https://coinweb.com/trends/how-many-crypto-wallets-are-there/). Given there is no option to mint new love tokens, this would actually ruin the functionality of the protocol of finding soulmates and shift the focus to abusing a sybil attack to farming airdrops instead. Assigning medium severity for now but am open for appeals otherwise, since most if not all issues lack indepth analysis of the issue.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.