Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: low
Valid

safeMint() is not used

Summary

In the mintSoulmateToken() function _mint(msg.sender, nextID++) is used to mint the NFT for the 1st soulmate.

Vulnerability Details

In the mintSoulmateToken() function _mint(msg.sender, nextID++) is used to mint the NFT for the 1st soulmate.

Impact

If the mintSoulmateToken()is called by a smart contract and necessary function is not defined to accept NFTs _mint(msg.sender, nextID++) can revert

Tools Used

Manual code review

Recommendations

It's recommended to use safeMint() instead of mint()

Updates

Lead Judging Commences

0xnevi Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-safemint

Low severity, - If a user utilizes an EOA, the check is not required. - If a user utilizes a contract that they own to mint soulmate tokens, than check is required. However, this would rely on user error minting. Since there is no mention that ownership of token must be from EOAs, I believe low severity is appropriate.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.