Submission Details
Severity:
Possible to update "message" even if divorced
Summary
writeMessageInSharedSpace() allows soulmates to write messages to each other.
Vulnerability Details
There is no check if the soulmates are divorced or not.
Impact
Soulmates can call writeMessageInSharedSpace() even if they are divorced
function test_divorcedCanWriteMessage() public {
_mintOneTokenForBothSoulmates();
vm.startPrank(soulmate1);
soulmateContract.getDivorced();
soulmateContract.writeMessageInSharedSpace("hellow");
}
Tools Used
manual review
Recommendations
It's recommended to ad a check like below to writeMessageInSharedSpace() function:
if (isDivorced()) revert revert Soulmate__coupleDivorced();
Rewards breakdown
nSLOC
233This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.