First Flight #9: Soulmate

Beginner FriendlyFoundryNFT
100 EXP
Ended
Submission Details
Severity: low
Invalid

No way to increase the total supply of LoveToken as it allows minting only once.

https://github.com/Cyfrin/2024-02-soulmate/blob/main/src/Vault.sol#L28

Summary

There is no way to mint more KittyToken inside the Vault, as a result of which soulmates will not be able to claim Airdrop or get staking rewards for them being soulmates or staking amount respectively.
LoveToken is used to represent how much love there is between two soulmates, as mentioned by the protocol.
But when there is no LoveToken, they cannot show their love to the world.

Vulnerability Details

The vulnerability occurs due to fixed total supply of LoveToken, and more LoveToken cannot be minted and soulmates can no longer claim LoveToken.

Impact

  • Soulmates cannot claim LoveToken'

  • Users will not be able to receive their staking rewards

Tools Used

Manual Review

Recommendations

Admins should be able to mint more LoveToken, when LoveToken becomes scarce.

Updates

Community Judging Commences

Community Judging Judge
11 months ago
Community Judgement Published
100% Invalid

Lead Judging Commences

0xnevi Lead Judge 11 months ago
Submission Judgement Published
Invalidated
Reason: Design choice

Barring the sybil attack mentioned in #255 which none of the following issues mentioned, I believe the following issues to be design choice, as it would require 500_000_000 weeks spread across many users, seems sufficient.

It is a valid design choice to restrict staking rewards, so users should be aware about remaining staking rewards before deciding to participate as soulmates. Additionally, withdrawals are not blocked, and any intended rewards are still assigned to users that deserved the rewards based on love tokens staked.

Support

FAQs

Can’t find an answer? Join our Discord or follow us on Twitter.

Cyfrin
Updraft
CodeHawks
Solodit
Resources