First Flight #9: Soulmate

Summary

isDivorced check in Airdrop contract will never be false resulting in Divorced couples still allowed to claim their airdrops

Vulnerability Details

isDivorced function returns a boolean "true" if msg.sender is divorced, if the Airdrop.sol contract calls the function, it will read the state with the AirdropContract as the msg.sender, So it will always be false

and if (soulmateContract.isDivorced()) revert Airdrop__CoupleIsDivorced();

Impact

Divorced couples can still claim their airdrops

Tools Used

Manual Review

Recommendations

use tx.origin or pass the msg.sender as a parameter