15,000 USDC
Submission Details
Severity:
repayBadDebtWithCash() function can be called with amount = 0
Summary
In contract MErc20DelegateFixer, the repayBadDebtWithCash() function can be called with argument amount = 0.
Vulnerability Details
Calling the function with amount = 0 emits the event BadDebtRepayed(0), which means no debt has been payed at all. This is undesirable as introduces new information which really contributes nothing, the rest of the variables of the system are not affected.
Impact
Low impact as it does not affect the operation of the protocol.
Tools Used
Manual review
Recommendations
Add a check to prevent from calling the function with argument amount = 0:
function repayBadDebtWithCash(uint256 amount) external nonReentrant {
+ require(amount > 0, "Some debt must be paid!");
/// Checks and Effects
badDebt = SafeMath.sub(badDebt, amount, "amount exceeds bad debt");
EIP20Interface token = EIP20Interface(underlying);
/// Interactions
require(
token.transferFrom(msg.sender, address(this), amount),
"transfer in failed"
);
emit BadDebtRepayed(amount);
}
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
39438 USDC / LOC
14,000 USDC
1,000 USDC
1,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.