Moonwell

Moonwell
DeFiFoundry
15,000 USDC
View results
Submission Details
Severity: low
Invalid

Proposal isn't overriding `name()` function in `mipm17` contract as specified by Forge Proposal Simulator

Vulnerability Details

The project chooses Forge Proposal Simulator as framework for creating secure governance proposals. Documentation of FPS specifies here

function name() external: Override this function with a state variable to define the proposal name.

But the current implementation doesn't override the function instead implements the name as string instead of separate function.

string public constant override name = "MIP-M17";

Impact

The old version of FPS may fail to deliver expected behaviour as name() is implemented as function instead of string. There is again no getter function to know about the name of proposal in the current implementation.

Tools Used

Manual Review

Recommendations

We recommend to use the latest version of FPS library and change the implementation to a name() function.

Updates

Lead Judging Commences

0xnevi Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Other

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.