Moonwell

Moonwell
DeFiFoundry
15,000 USDC
View results
Submission Details
Severity: low
Invalid

Contract is used as test

Summary

The mip-m17.sol contract is a regular contract that will be deployed. As per the documentation it's purpose is MIP-M17 Governance Proposal. However the contract is implemented in a wrong way.

Vulnerability Details

First we can see that some of the imports are @forge-std/Test.sol and @forge-std/console.sol. These imports must be used only in contracts used for testing. We can also see some cheat codes used only for testing. They are vm.readFile and vm.parseJson, assertEq is used too for comparing values.

Impact

Wrong implementation of contract that will be deployed.

Tools Used

Manual Review

Recommendations

Rewrite the whole logic and do not use keywords for testing contracts.

Updates

Lead Judging Commences

0xnevi Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Other

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.