Summary

"mintCatToNewOwner()" with "dob" parameter, might lead to overflow/underflow.

Vulnerability Details

"mintCatToNewOwner()" with "dob" parameter, might lead to overflow/underflow, inside getCatAge() since there is this piece of code there:

resulting a revert inside getCatAge(), depending on what has been passe initially inside "mintCatToNewOwner()";

Impact

Medium, nobody will be able to fetch the given cat age.

Tools Used

Manual review.

Recommendations

Do not pass "dob" as parameter to mintCatToNewOwner() instead keep it internal, cause obviously the dateOfBirth can be the time when mintCatToNewOwner() is called so "dob: block.timestamp" inside the "CatInfo" struct will do the job.