First Flight #12: Kitty Connect

First Flight #12: Kitty Connect
Beginner FriendlyFoundryNFTGameFi
100 EXP
View results
Submission Details
Severity: high
Valid

Missed adding "tokenId" to the "s_ownerToCatsTokenId" when "mintBridgedNFT()"

Summary

Missed adding "tokenId" to the "s_ownerToCatsTokenId" when "mintBridgedNFT()".

Vulnerability Details

When "mintBridgedNFT()" function is called it is forgotten to add the "tokenId" to the list that keeps track of the nfts of the owner
"s_ownerToCatsTokenId" resulting to inconsistencies when bridging.

Impact

High, since this token won't be tracked as part of the entries of the owner, resulting to inconsistencies when bridging.

Tools Used

Manual review

Recommendations

Line such as this to be added just before emitting the "NFTBridged" event:

s_ownerToCatsTokenId[catOwner].push(tokenId);
Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

owner's token ID array not updated in `mintBridgedNFT`

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.