KittyConnect.sol::mintCatToNewOwner
doesn't follow the CEI pattern.Description:
KittyConnect.sol::mintCatToNewOwner
emits the KittyConnect.sol::CatMinted
after a function call.
Impact:
Event emission after calls can open opportunities for the manipulation of events. If this event is being monitored by another mechanism it can lead to unexpected outcomes.
Recommendation:
Always follow the CEI pattern.
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.