First Flight #12: Kitty Connect

First Flight #12: Kitty Connect
Beginner FriendlyFoundryNFTGameFi
100 EXP
View results
Submission Details
Severity: low
Invalid

`KittyConnect.sol::mintCatToNewOwner` doesn't follow the CEI pattern.

KittyConnect.sol::mintCatToNewOwner doesn't follow the CEI pattern.

  • Description:

    • KittyConnect.sol::mintCatToNewOwner emits the KittyConnect.sol::CatMinted after a function call.

  • Impact:

    • Event emission after calls can open opportunities for the manipulation of events. If this event is being monitored by another mechanism it can lead to unexpected outcomes.

  • Recommendation:

    • Always follow the CEI pattern.

Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.