First Flight #12: Kitty Connect

First Flight #12: Kitty Connect
Beginner FriendlyFoundryNFTGameFi
100 EXP
View results
Submission Details
Severity: low
Invalid

Several `KittyBridge.sol` functions don't emit events after storage update.

Several KittyBridge.sol functions don't emit events after storage update.

  • Description:

    • The following functions don't implement events after storage update:

      Verify instances below
      function allowlistDestinationChain(uint64 _destinationChainSelector, bool allowed) external onlyOwner {
      allowlistedDestinationChains[_destinationChainSelector] = allowed;
      }
      function allowlistSourceChain(uint64 _sourceChainSelector, bool allowed) external onlyOwner {
      allowlistedSourceChains[_sourceChainSelector] = allowed;
      }
      function allowlistSender(address _sender, bool allowed) external onlyOwner {
      allowlistedSenders[_sender] = allowed;
      }
      function updateGaslimit(uint256 gasLimit) external onlyOwner {
      gaslimit = gasLimit;
      }
  • Impact:

    • Loss of transparency on protocol process dificulting track of critical information.

  • Recommendation:

    • Follow best practices and always emit an event after storage update.

Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.