Submission Details
Severity:
Event emittion after call in `mintCatToNewFunction`
Summary
Event emittion after call in mintCatToNewFunction
Vulnerability Details
In the mintCatToNewFunction function, we emit the CatMinted event after the call to the _safeMint function. This does not follow CEI pattern and it consider a better practice to emit the event before any calls and let these calls be the last thing in the function.
Tools Used
Manual review
Recommendations
Consider changing the order of the code like this:
- _safeMint(catOwner, tokenId);
- emit CatMinted(tokenId, catIpfsHash);
+ emit CatMinted(tokenId, catIpfsHash);
+ _safeMint(catOwner, tokenId);
Rewards breakdown
nSLOC
235This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.