Submission Details
Severity:
`addShop` method doesn't check if the shop already exists
Summary
addShop method doesn't check if the shop already exists
Vulnerability Details
In the addShop method, we push a new shop partner in the s_kittyShops but we don't check if the shop already exists and it is already in the array.
Impact
Can lead to duplicates in shop partners array and excessive increase in gas costs and storage.
Tools Used
Manual review
Recommendations
Consider adding a require that checks if the shop partner already exists in the array like this :
function addShop(address shopAddress) external onlyKittyConnectOwner {
+ require(!s_isKittyShop[shopAddress], "Shop already exists");
s_isKittyShop[shopAddress] = true;
s_kittyShops.push(shopAddress);
emit ShopPartnerAdded(shopAddress);
}
Rewards breakdown
nSLOC
235This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.