Beginner FriendlyFoundryGameFi
100 EXP
View results
Submission Details
Severity: low
Invalid

Missing Files,Functions,Scripts and TestSuites may result in issues later

Summary

The File specialMartenitsaToken.sol is in scope but the file doesn't exist in repo, MartenitsaMarketplace::cancelListing is in documentation but not in actual code also the deployment Script and helperconfig for the Project are not provided ,There are no integration tests
Suites provided.

Impact

  1. Missing Files like specialMartenitsaToken.sol and Functions like MartenitsaMarketplace::cancelListing if added later will result in serious issues to arise even if the rest of the code is audited.

  2. Every Project requires a deployment Script to finally deploy the script ,they may have issues and should be thoroughly audited.

  3. The Project has test suites which only has unit tests even though they have a near 100% coverage ,there should also be Integration tests performed to know how one module works with other.

Recommendations

Providing the missing files and functions and test suites for the audit will help in mitigating many more issues.

Updates

Lead Judging Commences

bube Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.