First Flight #13: Baba Marta

Summary

Variable Shadowing occurs when the variables in the parent contract use the same name as the variables in the base contract which can lead to unexpected behaviours.here the variable Variable owner of MartenitsaToken::updateCountMartenitsaTokensOwner and MartenitsaToken::getCountMartenitsaTokensOwner is shadowing owner variable of Ownable contract

Impact

Although it doesn't pose any serious risk as the contract version is greater than 0.6.0, Variable Shadowing if not intended should be avoided

Recommendations

Renaming the arguments in MartenitsaToken::updateCountMartenitsaTokensOwner and MartenitsaToken::getCountMartenitsaTokensOwner functions will mitigate this issue.