Beginner FriendlyFoundryGameFi
100 EXP
View results
Submission Details
Severity: medium
Valid

Failure of token sale in marketplace

Summary

Listed token will not successfully transferred to the buyer

Vulnerability Details

Since the marketplace was not approved by the seller at the time of listing, the marketplace contract won't be able to successfully transfer the token from the seller to the buyer.

Impact

No sales will ever happen in the marketplace

Tools Used

Manual review

Recommendations

Add an approve function in listMartenitsaForSale function so the marketplace contract is approved by the seller for the tokenId, which will enable the marketplace to do a transfer to the buyer.

Updates

Lead Judging Commences

bube Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

Lack of approval

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.