First Flight #13: Baba Marta

Summary

Collected rewards is getting reassigned instead of being updated

Vulnerability Details

_collectedRewards[msg.sender] only reflecting the previous rewards he's redeemed, and not the whole rewards collected based on token balance.

Impact

This would lead to the user being able to receive more HealthTokens than his proper share.

Tools Used

Manual review

Recommendations

Update _collectedRewards[msg.sender] = amountRewards; with _collectedRewards[msg.sender] += amountRewards;