Submission Details
Severity:
Token Id pushed multiple times
Summary
Token Id pushed possibly multiple times as part of the vote count
Vulnerability Details
Token ID being pushed into _tokenIds array whenever a vote for the token Id is counted
Impact
Counting votes and deciding the winner will be very gas consuming since the _tokenIds array will be much longer than required
Tools Used
Manual review
Recommendations
Do a check whethertokenId is already in the _tokenIds array before pushing
replace line 51 with:
if(voteCounts[tokenId]==1) {
_tokenIds.push(tokenId);
}
Updates
Lead Judging Commences
bube over 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Unbounded arrays
Rewards breakdown
nSLOC
239This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.