Submission Details
Severity:
User can transfer `MartenitsaToken` using directly `safetransferFrom` and not `makePresent` function.
Summary
MartenitsaToken can be transferred with the function safetransferFrom by any user without the need to use makePresent function.
Vulnerability Details
safetransferFrom of ERC721 MartenitsaToken is not overwritten.
Impact
Users can transfer the ‘MartenitsaTokenwithout affecting theCountMartenitsaTokensOwnerby directly using thesafetransferFromfunction. Using this method may lead to wrong rewards calculationHealthTokens` for those users
Tools Used
Manual review
Recommendations
Make these changes to the codebase of MartenitsaToken contract:
+ function safeTransferFrom() override public {
+ require(msg.sender == address(_martenitsaMarketplace), "Unable to call this function");
+ }
Updates
Lead Judging Commences
bube over 1 year ago
Submission Judgement Published Assigned finding tags:
ERC721 `transferFrom` not overriden
Rewards breakdown
nSLOC
239This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.