Beginner FriendlyFoundryGameFi
100 EXP
View results
Submission Details
Severity: low
Invalid

Potential DOS when voting for a Martenitsa token

Summary

There is a potential Denial Of Service when voting for a Martenitsa token.

Vulnerability Details

In MartenitsaVoting.sol, voteForMartenitsa() pushes tokenId to _tokenIds on each vote, regardless of repeated votes on the same tokenId. This can cause _tokenIds to grow excessively, leading to high gas costs and potential DOS if it surpasses the block gas limit.

Impact

High gas costs at least, DOS at worst.

Tools Used

Manual review.

Recommendations

Use a mapping to track whether a tokenId has been voted for.

Updates

Lead Judging Commences

bube Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Unbounded arrays

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.