Submission Details
Severity:
Potential DOS when voting for a Martenitsa token
Summary
There is a potential Denial Of Service when voting for a Martenitsa token.
Vulnerability Details
In MartenitsaVoting.sol, voteForMartenitsa() pushes tokenId to _tokenIds on each vote, regardless of repeated votes on the same tokenId. This can cause _tokenIds to grow excessively, leading to high gas costs and potential DOS if it surpasses the block gas limit.
Impact
High gas costs at least, DOS at worst.
Tools Used
Manual review.
Recommendations
Use a mapping to track whether a tokenId has been voted for.
Updates
Lead Judging Commences
bube over 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Unbounded arrays
Rewards breakdown
nSLOC
239This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.