Beginner FriendlyFoundryGameFi
100 EXP
View results
Submission Details
Severity: medium
Valid

No logic to handle multiple vote winners

Summary

There is no logic to handle multiple vote winners.

Vulnerability Details

In MartenitsaVoting.sol, announceWinner() does not account for multiple tokens having the same maxVotes. Only the first one found in _tokenIds array will be considered the winner.

Impact

Unfairness in reward distribution.

Tools Used

Manual review.

Recommendations

Consider adding logic to handle multiple tokens having the same maxVotes.

Updates

Lead Judging Commences

bube Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

Tie in voting is not considered

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.