Submission Details
Severity:
LibMath::roundUpDiv() no check for division by zero
Summary
Function roundUpDiv() in LibMath.sol library does not check if b parameter is zero
Vulnerability Details
As written in summary: roundUpDiv() function does not check if denominator is zero
Impact
Dividing by zero will cause unexpected error
Tools Used
Foundry test:
// SPDX-License-Identifier: MIT
pragma solidity ^0.8.20;
import {Test, console} from "forge-std/Test.sol";
import {LibMath} from "../../src/libraries/LibMath.sol";
contract LibMathTest is Test {
using LibMath for uint256;
function setUp() public {}
function testRoundUpDiv() public pure {
uint256 a = 2;
uint256 b = 0;
a.roundUpDiv(b);
}
}
Result of the test:
[FAIL. Reason: panic: division or modulo by zero (0x12)] testRoundUpDiv() (gas: 402)
Traces:
[402] LibMathTest::testRoundUpDiv()
└─ ← [Revert] panic: division or modulo by zero (0x12)
Recommendations
Add following line at the beginning of roundUpDiv() function:
require(b > 0);
Updates
Lead Judging Commences
giovannidisiena over 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Informational/Invalid
Prize pool breakdown
Total prize
12,000 USDC
nSLOC
47925 USDC / LOC
10,000 USDC
1,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.