Beanstalk: Dive Into Basin

Summary

In the _init() function, there is a loop that checks if _reserve is zero and returns if so, but this check is not present in other functions that also handle reserves, such as readInstantaneousReserves(), readCappedReserves(), and others. This inconsistency could lead to unexpected behavior if zero reserves are encountered outside of initialization.

Vulnerability Details

Here's the relevant part from _init():

init()

In other functions there is no explicit check for zero reserves before proceeding with calculations that assume non-zero values.

Impact

This could potentially lead to incorrect calculations or other unintended effects.

Tools Used

Manual Review

Recommendations

Add a check after retrieving the current reserves. If any reserve is zero, the function could revert or handle it according to the intended logic.
This approach prevents any subsequent calculations from being performed with a zero reserve, which could lead to incorrect results or mathematical errors.