Submission Details
Severity:
Possible zero denominator inside the `roundUpDiv()` function
Summary
Function roundUpDiv() does not check for a possible zero denominator
Vulnerability Details
The internal roundUpDiv() function does not check if the denominator b is zero. The function will revert in the case of a possible zero denominator before rounding it up, thus breaking its intended logic. Calling functions likeroundUpDiv() from another contract should never revert.
Impact
Reverting in the case of a possible zero denominator, breaking the logic
Tools Used
Manual Review
Recommendations
Consider checking the denominator to not be zero:
function roundUpDiv(uint256 a, uint256 b) internal pure returns (uint256) {
+ require(b != 0, "ZERO DENOMINATOR");
if (a == 0) return 0;
return (a - 1) / b + 1;
}
Updates
Lead Judging Commences
giovannidisiena about 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Informational/Invalid
Prize pool breakdown
Total prize
12,000 USDC
nSLOC
47925 USDC / LOC
10,000 USDC
1,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.