Sablier

Summary

Some ERC20 tokens revert on zero value transfers.

Vulnerability Details

function clawback(address to, uint128 amount) external override onlyAdmin {
// Check: current timestamp is over the grace period and the campaign has not expired.
if (_hasGracePeriodPassed() && !hasExpired()) {
revert Errors.SablierV2MerkleLockup_ClawbackNotAllowed({
blockTimestamp: block.timestamp,
expiration: EXPIRATION,
firstClaimTime: _firstClaimTime
});
}

    // Effect: transfer the tokens to the provided address.

@>> ASSET.safeTransfer(to, amount);

    // Log the clawback.
    emit Clawback(admin, to, amount);
}

Impact

Some ERC20 tokens revert on zero value transfers:

https://github.com/d-xo/weird-erc20#revert-on-zero-value-transfers

Tools Used

Recommendations

check for amount>0;