Sablier

Sablier
DeFiFoundry
53,440 USDC
View results
Submission Details
Severity: low
Invalid

the `_calculateStreamedAmount()` in lockup dynamic doesn't implement the stream start time right

Summary

the _calculateStreamedAmount() in lockup dynamic doesn't implement the stream's start time right

Vulnerability Details

in the SablierV2LockupDynamic.sol contract the _calculateStreamedAmount() will return 0 if the Stream.startTime is grater or equal to the timestamp while it should calculate the streamed amount if the start time is equal to the timestamp.

Impact

it doesn't impact the logic, but the real start time is actually Stream.startTime + 1 second.

Tools Used

Recommendations

remove the equal sign in this line:
https://github.com/Cyfrin/2024-05-Sablier/blob/449257087fead2877a72fed5ce042549d81bd5a2/v2-core/src/SablierV2LockupDynamic.sol#L194

Updates

Lead Judging Commences

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.